Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files without text to index? #57

Closed
TobiX opened this issue Apr 18, 2018 · 2 comments
Closed

Add files without text to index? #57

TobiX opened this issue Apr 18, 2018 · 2 comments

Comments

@TobiX
Copy link
Contributor

TobiX commented Apr 18, 2018

When a file isn't added to the index because it's not text, you cannot even find its file name. Would it be possible/desirable to at least add the file to the index as an "empty" file (maybe setting the language to "binary")?

Bonus points if the user can even see why the file was excluded. Hound does this:

grafik

I'm willing to implement this myself, just wanted to ask if this is something that sounds useful.

@hanwen
Copy link
Contributor

hanwen commented Apr 18, 2018

yes. Good idea.

A quick solution is to just replace the body with the reason. More advanced would be to add a new field (which would require an index version bump.)

@heltonmarx
Copy link
Contributor

Hi @hanwen

I'm working on this task and I submitted it to Gerrit (here).
If you have any comments or suggestions please feel free to let me know.

@hanwen hanwen closed this as completed in 8029ba6 May 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants