Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use lodash-es and not lodash #1041

Closed
bjornharvold opened this issue Apr 13, 2022 · 2 comments
Closed

Use lodash-es and not lodash #1041

bjornharvold opened this issue Apr 13, 2022 · 2 comments
Assignees
@Kiro705
Labels
enhancement P3

Comments

@bjornharvold
Copy link

Unless you are using the entire feature set of lodash, lodash-es ismore modular.
@bjornharvold bjornharvold mentioned this issue Apr 13, 2022
Closed
@Kiro705
Copy link
Member

Kiro705 commented May 24, 2022

Hello @bjornharvold ,

I will look into minimizing the importing of lodash in the next release.

Thank you,
Jackson
IMA SDK team

@Kiro705 Kiro705 self-assigned this May 24, 2022
@Kiro705
Copy link
Member

Kiro705 commented Jun 6, 2022

This commit removes lodash, as it is not used directly by this repo's code.

4eab3cf

@Kiro705 Kiro705 closed this as completed Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kiro705 Kiro705

Labels
enhancement P3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bjornharvold @Kiro705