Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: undelete should not be required for declarative-friendly interfaces #1304

Merged
merged 4 commits into from
Dec 20, 2023
Merged

feat: undelete should not be required for declarative-friendly interfaces #1304

merged 4 commits into from
Dec 20, 2023

Conversation

andrei-scripniciuc
Copy link
Contributor

according to https://google.aip.dev/164#declarative-friendly-resources:

Soft-deletable resources have a poorer experience than hard-deleted resources in declarative clients

this contradicts the requirement that declarative-friendly interfaces implement soft-delete.

@andrei-scripniciuc andrei-scripniciuc requested a review from a team as a code owner December 20, 2023 21:27
Copy link
Collaborator

@noahdietz noahdietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the appropriate docs/ page as well

@noahdietz noahdietz changed the title feat:undelete should not be required for declarative-friendly interfaces feat: undelete should not be required for declarative-friendly interfaces Dec 20, 2023
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@bgrant0607
Copy link

@noahdietz noahdietz added the automerge Summon MOG for automerging label Dec 20, 2023
@bgrant0607
Copy link

Ok, this is just removing the check from 164, not from everywhere.

@gcf-merge-on-green gcf-merge-on-green bot merged commit b40c90d into googleapis:main Dec 20, 2023
6 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Summon MOG for automerging label Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants