Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(AIP-151): allow batch delete an Empty response #1136

Merged
merged 2 commits into from
Apr 13, 2023
Merged

fix(AIP-151): allow batch delete an Empty response #1136

merged 2 commits into from
Apr 13, 2023

Conversation

noahdietz
Copy link
Collaborator

Allow BatchDelete to use Empty response as is allowed in AIP-235.

Fixes #1092

@noahdietz noahdietz requested a review from a team as a code owner April 13, 2023 15:20
@noahdietz noahdietz added the automerge Summon MOG for automerging label Apr 13, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 78bf96d into googleapis:main Apr 13, 2023
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Summon MOG for automerging label Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toumorokoshi toumorokoshi toumorokoshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AIP-151: google.protobuf.Empty should be an allowed response type for Standard/Batch Delete Methods with LRO
2 participants
@noahdietz @toumorokoshi