feat(AIP-162): lint operation_info response_type #1137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toumorokoshi
approved these changes
Apr 13, 2023
| loc := locations.MethodResponseType(m) | ||
|
|
||
| // If LRO, check the response_type short name. | ||
| if utils.IsOperation(m.GetOutputType()) { |
There was a problem hiding this comment.
do you think this is worth refactoring to it's own method?
feels like getting the response type from an LRO is a common operation.. or to go a level farther: a utility method to get a response type from a method regardless of whether it's an LRO or not (do the unpacking in the utility method).
There was a problem hiding this comment.
I think it could be useful for sure.
I think at least some of the code that does similar checks to extract the response type will also want to know if it is an LRO or not for another reason (i.e. which Location to provide to the finding).
Could be a nice clean up though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
RollbackRPCs to use LRO, and lint theresponse_typeas if it were the RPC return type.Do some light refactoring of "is a longrunning operation" checks, favoring a new helper method.
Fixes #1063