Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(AIP-203): remove required-and-optional rule #1178

Merged
merged 1 commit into from
Jun 20, 2023
Merged

fix(AIP-203): remove required-and-optional rule #1178

merged 1 commit into from
Jun 20, 2023

Conversation

noahdietz
Copy link
Collaborator

@noahdietz noahdietz commented Jun 20, 2023 •
edited
Loading

Remove rule that prohibited use of REQUIRED and proto3_optional. See aip-dev/google.aip.dev#1143 for AIP change.

Fixes #1169

@noahdietz noahdietz marked this pull request as ready for review June 20, 2023 21:15
@noahdietz noahdietz requested a review from a team as a code owner June 20, 2023 21:15
@noahdietz noahdietz requested review from toumorokoshi and removed request for toumorokoshi June 20, 2023 23:07
@noahdietz noahdietz merged commit 73fe862 into googleapis:main Jun 20, 2023
6 checks passed
@noahdietz noahdietz deleted the remove-required-proto3-optional branch June 20, 2023 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jskeet jskeet jskeet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AIP-203: Remove required-and-optional rule?
2 participants
@noahdietz @jskeet