feat(AIP-122): disallow embedded resource #1245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toumorokoshi
approved these changes
Aug 30, 2023
| ## Disabling | ||
|
|
||
| If you need to violate this rule, use a leading comment above the method. | ||
| Remember to also include an [aip.dev/not-precedent][] comment explaining why. |
There was a problem hiding this comment.
this might be a good place to link to notable exceptions in the AIPs.
toumorokoshi
suggested changes
Aug 30, 2023
toumorokoshi
approved these changes
Aug 31, 2023
There was a problem hiding this comment.
Great, thanks for doing that!
I think this can be merged even without merging aip-dev/google.aip.dev#1192: no one is using the revisions pattern yet anyway, so the existence of the condition wouldn't impact it's usage as a check now.
I agree! Good idea. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disallow embedding resources in other resources, use resource_references instead.
Enforce guidance added in aip-dev/google.aip.dev#1196.