feat: Add rules for AIP-164 Undelete #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
lukesneeringer
changed the title
lukesneeringer
approved these changes
Oct 14, 2020
| for _, test := range tests { | ||
| t.Run(test.testName, func(t *testing.T) { | ||
| // Create a MethodOptions with the annotation set. | ||
| opts := &dpb.MethodOptions{} |
There was a problem hiding this comment.
I am surprised you went this route and not testutils.ParseProto3Tmpl, but it is fine as it is.
There was a problem hiding this comment.
I just copied it from one of the other tests that was similar. It'd be good at some point to upgrade all the tests to use ParseProto3Tmpl.
There was a problem hiding this comment.
Ah, that makes sense. Yeah, I wrote about 20 or so rules before writing ParseProto3Tmpl, which required me to get a change in to the underlying protoreflect library.
There was a problem hiding this comment.
I really miss g4 cp in GitHub's PR UI, to make these changes more obvious.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #666, #667, #668.