Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

feat: add active debuggee support #1121

Merged
merged 10 commits into from
Dec 9, 2022
Merged

Conversation

mctavish
Copy link
Contributor

@mctavish mctavish commented Dec 8, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1120 🦕

@mctavish mctavish requested review from a team as code owners December 8, 2022 16:28
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: clouddebugger Issues related to the googleapis/cloud-debug-nodejs API. labels Dec 8, 2022
@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Base: 65.74% // Head: 65.88% // Increases project coverage by +0.14% 🎉

Coverage data is based on head (bb46c0c) compared to base (42ee4a7).
Patch coverage: 94.73% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1121      +/-   ##
==========================================
+ Coverage   65.74%   65.88%   +0.14%     
==========================================
  Files          19       21       +2     
  Lines        1769     1791      +22     
  Branches      354      355       +1     
==========================================
+ Hits         1163     1180      +17     
- Misses        520      524       +4     
- Partials       86       87       +1     
Impacted Files Coverage Δ
src/agent/firebase-controller.ts 69.02% <94.73%> (+3.02%) ⬆️
.mocharc.js 62.50% <0.00%> (ø)
.prettierrc.js 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mctavish mctavish added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 8, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 8, 2022
src/agent/firebase-controller.ts Outdated Show resolved Hide resolved
src/agent/firebase-controller.ts Show resolved Hide resolved
@mctavish mctavish added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 8, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 8, 2022
@mctavish mctavish added automerge Merge the pull request once unit tests and other checks pass. and removed automerge Merge the pull request once unit tests and other checks pass. labels Dec 8, 2022
@mctavish mctavish merged commit a421509 into googleapis:main Dec 9, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 9, 2022
@mctavish mctavish deleted the active-debuggee branch December 9, 2022 13:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: clouddebugger Issues related to the googleapis/cloud-debug-nodejs API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add active debuggee support for the firebase backend
2 participants