Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set version equal to module version #893

Closed
wants to merge 3 commits into from

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Feb 11, 2022

As of googleapis/google-cloud-go#5517 we
now have a version file in the internal package for every module.
This change reads variable and uses it for the client version. This
means all autogenerated clients will now get a meaningful realease
version in thier call metadata.

As of googleapis/google-cloud-go#5517 we
now have a version file in the internal package for every module.
This change reads variable and uses it for the client version. This
means all autogenerated clients will now get a meaningful realease
version in thier call metadata.
@codyoss
Copy link
Member Author

codyoss commented Feb 11, 2022

@noahdietz This is a little hacky but something roughly like this is what I was thinking... LMK WYT

@noahdietz
Copy link
Collaborator

I want to make this happen because it will be useful. My main concern is that a Go gapic is no longer compilable without the addition of the internal.Version variable. Let's figure out how we can overcome that. Perhaps with a flag of some sort that we only use in our regen pipeline? Or does the generator also generate that file with var Version = 0.1.0, and our pipeline only copies the generated file on the first generation of the pkg?

@noahdietz noahdietz closed this Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants