fix: [REGAPIC] Fix snake_case nested resource names in generated unit tests #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
eaball35
approved these changes
May 12, 2022
|
lgtm. Is there an issue # for this? |
|
I guess buganizer automatically started creating issues for "fix" PRs. But no issue in github. I thought it was too small of a problem to have an issue for it. Do you want me to create one? |
suztomo
pushed a commit
that referenced
this pull request
Dec 16, 2022
suztomo
pushed a commit
that referenced
this pull request
Mar 21, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [io.grpc:grpc-bom](https://togithub.com/grpc/grpc-java) | `1.50.1` -> `1.50.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>grpc/grpc-java</summary> ### [`v1.50.2`](https://togithub.com/grpc/grpc-java/releases/tag/v1.50.2) ##### Bug fixes gcp-observability: Supports period(.) in the service name part of regular expression for a fully-qualified method to accept "package.service" </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-core). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yNDAuNSIsInVwZGF0ZWRJblZlciI6IjMyLjI0MS4xMSJ9-->
](https://renovatebot.com){kind=link}
suztomo
pushed a commit
that referenced
this pull request
Mar 21, 2023
🤖 I have created a release *beep* *boop* --- ## [2.8.23](https://togithub.com/googleapis/java-core/compare/v2.8.22...v2.8.23) (2022-10-24) ### Dependencies * Update dependency io.grpc:grpc-bom to v1.50.2 ([#990](https://togithub.com/googleapis/java-core/issues/990)) ([275a212](https://togithub.com/googleapis/java-core/commit/275a212b73f6e9ea15d291f46296b7861c7a4efb)) * Update dependency org.easymock:easymock to v5 ([#980](https://togithub.com/googleapis/java-core/issues/980)) ([66a668f](https://togithub.com/googleapis/java-core/commit/66a668fd96ffe241660cb6cd2114290f4ff09697)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this fix we were comparing snake_case and camelCase of the same resource. Most often field names consist of one word (so both cases are the same), so this was not causing troubles.