Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename processor interface #639

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Conversation

bshaffer
Copy link
Contributor

I missed this the first time around, but all interfaces should be suffixed with Interface. This is not an official PHP standard, but it is standard across all the googleapis libraries we maintain.

@bshaffer bshaffer requested review from a team as code owners June 21, 2023 18:03
@bshaffer bshaffer requested a review from noahdietz June 21, 2023 18:04
@noahdietz
Copy link
Collaborator

Need to change the PostProcessor import and typing I think

@bshaffer
Copy link
Contributor Author

bshaffer commented Jul 5, 2023

Hmm, they were just flakey and needed to be rerun 💀

@bshaffer bshaffer merged commit abde218 into main Jul 5, 2023
5 checks passed
@bshaffer bshaffer deleted the rename-processor-interface branch July 5, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants