Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into conditionally using native fetch when we move to Node 18 #1597

Open
sofisl opened this issue May 16, 2024 · 2 comments
Open

Look into conditionally using native fetch when we move to Node 18 #1597

sofisl opened this issue May 16, 2024 · 2 comments
Assignees
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@sofisl
Copy link
Contributor

sofisl commented May 16, 2024

see b/337041278

Once we move to Node 18, we should look into checking whether we can use native fetch instead of node-fetch.

@sofisl sofisl added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. labels May 16, 2024
@danielbankhead
Copy link
Contributor

I’ve completed some research on the topic - see:

@sofisl
Copy link
Contributor Author

sofisl commented May 16, 2024

Awesome, thanks for doing that digging! We can use it to replace node-fetch here, as well.

@danielbankhead danielbankhead removed their assignment Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

2 participants