New serialization approach for the RequestBuilder #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #226 +/- ##
==========================================
+ Coverage 86.99% 91.31% +4.32%
==========================================
Files 68 49 -19
Lines 2552 2095 -457
==========================================
- Hits 2220 1913 -307
+ Misses 332 182 -150Continue to review full report at Codecov.
|
dwsupplee
added
the
do not merge
| @@ -121,8 +121,7 @@ | |||
| ], | |||
| 'MethodWithSpecialJsonMapping' => [ | |||
| 'method' => 'get', | |||
| 'uriTemplate' => '/v1/special/mapping', | |||
| 'placeholders' => [] | |||
| 'uriTemplate' => '/v1/special/mapping' | |||
There was a problem hiding this comment.
I don't understand how this change fits with the rest of the changes - do we need to remove placeholders? Or is it just cleanup?
There was a problem hiding this comment.
It was just cleanup, I can undo if you like. Let me know!
|
@dwsupplee protobuf 3.7.0 is out! https://github.com/protocolbuffers/protobuf/releases/tag/v3.7.0 Can we more this PR forward? |
|
Absolutely 😄 |
dwsupplee
removed
🚨
michaelbausor
added a commit
that referenced
this pull request
Mar 27, 2019
## Google ApiCore 1.0.0 Moving ApiCore to GA! ### RequestBuilding serialization approach - Added a new serialization approach in RequestBuilder (#226) ### Protobuf changes - Updated protobuf dependency to 3.7.1 (#232) - Added conflict section to composer.json to prevent protobuf extension conflict (#232) - Remove skip tests for protobuf extension (#230) ### Cleanup and dependencies - Update common-protos dependency to 1.0 (#231) - Update license files (#228)
michaelbausor
added a commit
that referenced
this pull request
Mar 27, 2019
## Google ApiCore 1.0.0 Moving ApiCore to GA! ### RequestBuilding serialization approach - Added a new serialization approach in RequestBuilder (#226) ### Protobuf changes - Updated protobuf dependency to 3.7.1 (#232) - Added conflict section to composer.json to prevent protobuf extension conflict (#232) - Remove skip tests for protobuf extension (#230) ### Cleanup and dependencies - Update common-protos dependency to 1.0 (#231) - Update license files (#228)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: googleapis/google-cloud-php#1583
This approach relies on
Google\Protobuf\Internal\Message::serializeToJsonString()as opposed to accessing private/protected variables on protobuf messages. Thanks to some great work over the last few weeks by @TeBoring and the rest of the protobuf team, we will be able to safely rely on this simpler approach with the next release of the protobuf extension.