Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conflict statement to composer.json #232

Merged
merged 2 commits into from
Mar 26, 2019

Conversation

michaelbausor
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 26, 2019
@codecov
Copy link

codecov bot commented Mar 26, 2019

Codecov Report

Merging #232 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #232   +/-   ##
=======================================
  Coverage   91.31%   91.31%           
=======================================
  Files          49       49           
  Lines        2095     2095           
=======================================
  Hits         1913     1913           
  Misses        182      182

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4496fc3...b343148. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 26, 2019

Codecov Report

Merging #232 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #232   +/-   ##
=======================================
  Coverage   91.31%   91.31%           
=======================================
  Files          49       49           
  Lines        2095     2095           
=======================================
  Hits         1913     1913           
  Misses        182      182

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4496fc3...b343148. Read the comment docs.

@dwsupplee dwsupplee merged commit 3ced1b1 into googleapis:master Mar 26, 2019
@michaelbausor michaelbausor deleted the add-conflict-to-composer branch March 26, 2019 20:04
michaelbausor added a commit that referenced this pull request Mar 27, 2019
## Google ApiCore 1.0.0

Moving ApiCore to GA!

### RequestBuilding serialization approach
- Added a new serialization approach in RequestBuilder (#226)

### Protobuf changes
- Updated protobuf dependency to 3.7.1 (#232)
- Added conflict section to composer.json to prevent protobuf extension conflict (#232)
- Remove skip tests for protobuf extension (#230)

### Cleanup and dependencies
- Update common-protos dependency to 1.0 (#231)
- Update license files (#228)
michaelbausor added a commit that referenced this pull request Mar 27, 2019
## Google ApiCore 1.0.0

Moving ApiCore to GA!

### RequestBuilding serialization approach
- Added a new serialization approach in RequestBuilder (#226)

### Protobuf changes
- Updated protobuf dependency to 3.7.1 (#232)
- Added conflict section to composer.json to prevent protobuf extension conflict (#232)
- Remove skip tests for protobuf extension (#230)

### Cleanup and dependencies
- Update common-protos dependency to 1.0 (#231)
- Update license files (#228)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants