Skip to content

Update licenses#228

Merged
michaelbausor merged 1 commit intogoogleapis:masterfrom
michaelbausor:update-licenses
Feb 28, 2019
Merged

Update licenses#228
michaelbausor merged 1 commit intogoogleapis:masterfrom
michaelbausor:update-licenses

Conversation

@michaelbausor
Copy link
Copy Markdown
Contributor

Fixes #204

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 28, 2019
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 28, 2019

Codecov Report

Merging #228 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #228   +/-   ##
=======================================
  Coverage   86.99%   86.99%           
=======================================
  Files          68       68           
  Lines        2552     2552           
=======================================
  Hits         2220     2220           
  Misses        332      332
Impacted Files Coverage Δ
src/RequestBuilder.php 93.65% <ø> (ø) ⬆️
src/Transport/Grpc/ForwardingUnaryCall.php 100% <ø> (ø) ⬆️
src/Transport/Grpc/ForwardingCall.php 100% <ø> (ø) ⬆️
src/PathTemplate.php 86.66% <ø> (ø) ⬆️
src/ApiStatus.php 85.71% <ø> (ø) ⬆️
src/ApiException.php 90% <ø> (ø) ⬆️
src/Transport/RestTransport.php 92.3% <ø> (ø) ⬆️
src/OperationResponse.php 91.13% <ø> (ø) ⬆️
src/Middleware/RetryMiddleware.php 98.14% <ø> (ø) ⬆️
src/Middleware/FixedHeaderMiddleware.php 100% <ø> (ø) ⬆️
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba141d4...71193ee. Read the comment docs.

Copy link
Copy Markdown
Contributor

@dwsupplee dwsupplee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelbausor michaelbausor merged commit 1cae4c4 into googleapis:master Feb 28, 2019
@michaelbausor michaelbausor deleted the update-licenses branch February 28, 2019 22:50
michaelbausor added a commit that referenced this pull request Mar 27, 2019
## Google ApiCore 1.0.0

Moving ApiCore to GA!

### RequestBuilding serialization approach
- Added a new serialization approach in RequestBuilder (#226)

### Protobuf changes
- Updated protobuf dependency to 3.7.1 (#232)
- Added conflict section to composer.json to prevent protobuf extension conflict (#232)
- Remove skip tests for protobuf extension (#230)

### Cleanup and dependencies
- Update common-protos dependency to 1.0 (#231)
- Update license files (#228)
michaelbausor added a commit that referenced this pull request Mar 27, 2019
## Google ApiCore 1.0.0

Moving ApiCore to GA!

### RequestBuilding serialization approach
- Added a new serialization approach in RequestBuilder (#226)

### Protobuf changes
- Updated protobuf dependency to 3.7.1 (#232)
- Added conflict section to composer.json to prevent protobuf extension conflict (#232)
- Remove skip tests for protobuf extension (#230)

### Cleanup and dependencies
- Update common-protos dependency to 1.0 (#231)
- Update license files (#228)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants