Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't set content-range on empty uploads #1070

Merged
merged 2 commits into from Oct 20, 2020

Conversation

@busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Oct 20, 2020

Fixes #638 馃

Setting the content-range header on an empty resumable upload results in 400 Invalid Argument. Only set the content-range if there is content. This is what the Java discovery client does (code).

TODO:

  • add unit test case
@google-cla google-cla bot added the cla: yes label Oct 20, 2020
@busunkim96 busunkim96 marked this pull request as ready for review Oct 20, 2020
@busunkim96 busunkim96 requested a review from googleapis/yoshi-python as a code owner Oct 20, 2020
@busunkim96 busunkim96 merged commit af6035f into googleapis:master Oct 20, 2020
3 of 4 checks passed
3 of 4 checks passed
Kokoro docs-presubmit Build failed
Details
Kokoro Build successful
Details
cla/google All necessary CLAs are signed
conventionalcommits.org
Details
efiop added a commit to iterative/PyDrive2 that referenced this pull request Oct 21, 2020
googleapis/google-api-python-client#1070 is now
merged, so we can get rid of our hack
#48
efiop added a commit to iterative/PyDrive2 that referenced this pull request Oct 21, 2020
googleapis/google-api-python-client#1070 is now
merged, so we can get rid of our hack
#48
efiop added a commit to iterative/PyDrive2 that referenced this pull request Oct 22, 2020
efiop added a commit to iterative/PyDrive2 that referenced this pull request Oct 22, 2020
googleapis/google-api-python-client#1070 is now
merged, so we can get rid of our hack
#48
efiop added a commit to iterative/PyDrive2 that referenced this pull request Oct 22, 2020
googleapis/google-api-python-client#1070 is now
merged, so we can get rid of our hack
#48
efiop added a commit to iterative/PyDrive2 that referenced this pull request Oct 22, 2020
googleapis/google-api-python-client#1070 is now
merged, so we can get rid of our hack
#48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can鈥檛 perform that action at this time.