Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gdrive: download empty file #48

Merged
merged 1 commit into from
Sep 21, 2020
Merged

gdrive: download empty file #48

merged 1 commit into from
Sep 21, 2020

Conversation

efiop
Copy link
Contributor

@efiop efiop commented Jul 26, 2020

@efiop
Copy link
Contributor Author

efiop commented Aug 9, 2020

Forgot about this PR, adding to the next sprint to sort it out.

@efiop efiop force-pushed the fix-empty-file branch 11 times, most recently from 759218b to 99bb813 Compare September 8, 2020 02:23
efiop added a commit to iterative/dvc that referenced this pull request Sep 8, 2020
Temporary workaround. Proper solution will be introduced in iterative/PyDrive2#48
@efiop efiop force-pushed the fix-empty-file branch 3 times, most recently from e153995 to 3c2be56 Compare September 8, 2020 03:13
pydrive2/files.py Outdated Show resolved Hide resolved
@efiop efiop force-pushed the fix-empty-file branch 3 times, most recently from 50ce41f to 7b478b7 Compare September 8, 2020 04:57
pydrive2/files.py Outdated Show resolved Hide resolved
@efiop efiop removed the request for review from shcheklein September 8, 2020 21:33
@efiop efiop changed the title gdrive: download empty file [WIP] gdrive: download empty file Sep 8, 2020
pydrive2/files.py Outdated Show resolved Hide resolved
@efiop efiop changed the title [WIP] gdrive: download empty file gdrive: download empty file Sep 8, 2020
@efiop efiop changed the title gdrive: download empty file [WIP] gdrive: download empty file Sep 8, 2020
pydrive2/files.py Outdated Show resolved Hide resolved
@efiop efiop force-pushed the fix-empty-file branch 2 times, most recently from 7252e53 to 764bb63 Compare September 9, 2020 03:56
pydrive2/files.py Show resolved Hide resolved
@efiop efiop force-pushed the fix-empty-file branch 3 times, most recently from fa05e40 to ba4e05a Compare September 21, 2020 12:00
@efiop efiop changed the title [WIP] gdrive: download empty file gdrive: download empty file Sep 21, 2020
@efiop
Copy link
Contributor Author

efiop commented Sep 21, 2020

Created #59 for a proper solution once google guys fix it on their end.

@shcheklein
Copy link
Member

thanks @efiop !

@efiop efiop merged commit 84a0b7a into master Sep 21, 2020
@efiop efiop deleted the fix-empty-file branch September 21, 2020 16:13
efiop added a commit that referenced this pull request Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants