-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gdrive: download empty file #48
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 28, 2020
Forgot about this PR, adding to the next sprint to sort it out. |
efiop
force-pushed
the
fix-empty-file
branch
11 times, most recently
from
September 8, 2020 02:23
759218b
to
99bb813
Compare
efiop
added a commit
to iterative/dvc
that referenced
this pull request
Sep 8, 2020
Temporary workaround. Proper solution will be introduced in iterative/PyDrive2#48
efiop
force-pushed
the
fix-empty-file
branch
3 times, most recently
from
September 8, 2020 03:13
e153995
to
3c2be56
Compare
efiop
commented
Sep 8, 2020
efiop
force-pushed
the
fix-empty-file
branch
3 times, most recently
from
September 8, 2020 04:57
50ce41f
to
7b478b7
Compare
shcheklein
reviewed
Sep 8, 2020
efiop
force-pushed
the
fix-empty-file
branch
from
September 8, 2020 06:18
7b478b7
to
669938d
Compare
efiop
force-pushed
the
fix-empty-file
branch
from
September 8, 2020 21:26
669938d
to
26fc6d4
Compare
shcheklein
reviewed
Sep 8, 2020
efiop
force-pushed
the
fix-empty-file
branch
from
September 8, 2020 22:58
d350a1f
to
2be2d84
Compare
shcheklein
reviewed
Sep 9, 2020
efiop
force-pushed
the
fix-empty-file
branch
2 times, most recently
from
September 9, 2020 03:56
7252e53
to
764bb63
Compare
efiop
commented
Sep 9, 2020
efiop
force-pushed
the
fix-empty-file
branch
3 times, most recently
from
September 21, 2020 12:00
fa05e40
to
ba4e05a
Compare
Created #59 for a proper solution once google guys fix it on their end. |
shcheklein
approved these changes
Sep 21, 2020
thanks @efiop ! |
efiop
added a commit
that referenced
this pull request
Oct 22, 2020
googleapis/google-api-python-client#1070 is now merged, so we can get rid of our hack #48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iterative/dvc#4286