replace multi_json dependency with regular stdlib JSON #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSON has been part of the ruby stdlib since 1.9.0 (see ruby/ruby@af1c4167), and the latest version of google-api-client requires ruby 2.0 or better so we can assume it's available
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
googlebot
added
the
cla: no
|
I've completed the CLA ✅ |
|
CLAs look good, thanks! |
googlebot
added
cla: yes
sqrrrl
added a commit
that referenced
this pull request
Feb 25, 2016
replace multi_json dependency with regular stdlib JSON
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSON has been part of the ruby stdlib since 1.9.0 (see ruby/ruby@af1c4167), and the latest version of this gem requires ruby 2.0 or better.
Would you consider removing multi_json as a dependency, and just using
require 'json'instead? Rails recently made a similar change (rails/rails#23453), which has prompted other libraries to consider the same issue (like simplecov and stripe).See also this recent blog post.