Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix generate-api names_out usage #787

Merged
merged 2 commits into from
May 10, 2019
Merged

Fix generate-api names_out usage #787

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
294a26f
Fix generate-api names_out usage
blowmage May 9, 2019
ad7343a
Only write names_out file when it does not exist
blowmage May 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions bin/generate-api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,9 @@ module Google
generate_from_url(options[:url]) if options[:url]
generate_from_file(options[:file]) if options[:file]
generate_from_discovery(preferred_only: options[:preferred_only]) if options[:from_discovery]
create_file(options[:names_out]) { |*| generator.dump_api_names } if options[:names_out]
if options[:names_out]
create_file(options[:names_out]) { |*| generator.dump_api_names } unless File.exist? options[:names_out]
end
end

desc 'list', 'List public APIs'
Expand Down Expand Up @@ -104,7 +106,7 @@ module Google
end

def generator
@generator ||= Google::Apis::Generator.new(api_names: options[:names])
@generator ||= Google::Apis::Generator.new(api_names: options[:names], api_names_out: options[:names_out])
end

def ensure_active_support
Expand Down