Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: Add invocation-id to x-goog-api-client header for c# storage #8881

Closed
danielduhh opened this issue Jul 12, 2022 · 2 comments · Fixed by #9312 or #9769
Closed

storage: Add invocation-id to x-goog-api-client header for c# storage #8881

danielduhh opened this issue Jul 12, 2022 · 2 comments · Fixed by #9312 or #9769
Assignees
Labels
api: storage Issues related to the Cloud Storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@danielduhh
Copy link

Tracking ticket to add a unique invocation-id to the x-goog-api-client header for all Storage API requests.
See nodejs example

@danielduhh danielduhh added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. api: storage Issues related to the Cloud Storage API. labels Jul 12, 2022
@jskeet
Copy link
Collaborator

jskeet commented Jul 13, 2022

@Rishabh-V: We'll need to work out how to integrate this with GAX (which populates the x-goog-api-client header). I'm not thrilled about this being within that header to be honest, but we'll see...

@Rishabh-V
Copy link
Contributor

Sure @jskeet

jskeet added a commit to jskeet/google-cloud-dotnet that referenced this issue Nov 10, 2022
jskeet added a commit to jskeet/google-cloud-dotnet that referenced this issue Nov 10, 2022
jskeet added a commit to jskeet/google-cloud-dotnet that referenced this issue Nov 10, 2022
jskeet added a commit to jskeet/google-cloud-dotnet that referenced this issue Nov 15, 2022
jskeet added a commit that referenced this issue Jan 23, 2023
Changes in this release:

### New features

- Improve credential support for URL signing. ([commit d36a8dd](d36a8dd))
- Add DownloadValidationMode.Automatic ([commit c9f2b19](c9f2b19))
- Support HMAC URL signing. ([commit dfad68e](dfad68e))
- Enable self-signed JWTs for Storage and Translation clients ([commit 10d2787](10d2787))
- Add invocation ID and attempt count in x-goog-api-client header. Fixes [issue 8881](#8881) ([commit 1ac6f68](1ac6f68))
- Disabled default ExponentialBackOffPolicy in message handler via StorageClientBuilder ([commit 62aec51](62aec51))

### Documentation improvements

- Add commentary on accidentally-optional parameters ([commit 228bdfc](228bdfc))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
3 participants