Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query Backfill Features #8791

Merged
merged 6 commits into from
Jun 22, 2022
Merged

Query Backfill Features #8791

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
caf98aa
WIP
anshuldavid13 Jun 16, 2022
f49b022
Updating test cases
anshuldavid13 Jun 20, 2022
cc9840e
Adding null check for collection
anshuldavid13 Jun 22, 2022
352e031
Review comments
anshuldavid13 Jun 22, 2022
4c23ae6
Review comments implemented
anshuldavid13 Jun 22, 2022
76fc832
Removing redundant ref
anshuldavid13 Jun 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions apis/Google.Cloud.Datastore.V1/Google.Cloud.Datastore.V1/FilterPartial.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,19 +76,25 @@ public static Filter NotEqual(string propertyName, Value propertyValue) =>
/// Creates a filter to check that the specified property is in a given array of values.
/// </summary>
/// <param name="value">The name of the property. Must not be null.</param>
/// <param name="collection">The array of values to compare against. </param>
/// <param name="collection">The array of values to compare against. Must not be null. </param>
/// <returns>The newly created filter.</returns>
public static Filter In(string value, ArrayValue collection) =>
Property(value, collection, Operator.In);
public static Filter In(string value, ArrayValue collection)
{
GaxPreconditions.CheckNotNull(collection, nameof(collection));
return Property(value, collection, Operator.In);
}

/// <summary>
/// Creates a filter to check that the specified property is not in a given array of values.
/// </summary>
/// <param name="value">The name of the property. Must not be null.</param>
/// <param name="collection">The array of values to compare against. </param>
/// <param name="collection">The array of values to compare against. Must not be null.</param>
/// <returns>The newly created filter.</returns>
public static Filter NotIn(string value, ArrayValue collection) =>
Property(value, collection, Operator.NotIn);
public static Filter NotIn(string value, ArrayValue collection)
{
GaxPreconditions.CheckNotNull(collection, nameof(collection));
return Property(value, collection, Operator.NotIn);
}

/// <summary>
/// Creates a filter to check that the specified property is less than a given value.
Expand Down