Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vision/v2): Release breaking changes as v2 module #6072

Merged
merged 5 commits into from
May 23, 2022

Conversation

quartzmo
Copy link
Member

BREAKING CHANGE: removed fields from SafeSearchAnnotation in googleapis/go-genproto#809

BREAKING CHANGE: removed fields from SafeSearchAnnotation in googleapis/go-genproto#809
@quartzmo quartzmo requested a review from a team as a code owner May 19, 2022 20:36
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: vision Issues related to the Cloud Vision API. labels May 19, 2022
vision/v2/README.md Outdated Show resolved Hide resolved
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just the one nit to fix

@quartzmo
Copy link
Member Author

@codyoss PTAL at my test fix, thanks.

@codyoss
Copy link
Member

codyoss commented May 23, 2022

@quartzmo Why did we have to make an exception for this v2 and not the last one with that one test?

@quartzmo quartzmo merged commit 9a4ff7f into googleapis:main May 23, 2022
@quartzmo quartzmo deleted the gen-vision-v2 branch May 23, 2022 18:41
@release-please release-please bot mentioned this pull request May 23, 2022
@qnighy
Copy link

qnighy commented Jan 30, 2023

Is it intentional that some files (apiv1/client.go, apiv1/image.go, etc.) are missing from the v2 directory? Is there documentation on how to migrate these APIs to v2?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: vision Issues related to the Cloud Vision API. size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants