-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vision/v2): Release breaking changes as v2 module #6072
Conversation
BREAKING CHANGE: removed fields from SafeSearchAnnotation in googleapis/go-genproto#809
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just the one nit to fix
@codyoss PTAL at my test fix, thanks. |
@quartzmo Why did we have to make an exception for this v2 and not the last one with that one test? |
Is it intentional that some files ( |
BREAKING CHANGE: removed fields from SafeSearchAnnotation in googleapis/go-genproto#809