fix(storage): specify credentials with STORAGE_EMULATOR_HOST #7271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
tritone
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
tritone
reviewed
Jan 19, 2023
There was a problem hiding this comment.
Thanks for the PR! I think this looks good to me. @BrennaEpp or @codyoss any thoughts?
|
@tritone @BrennaEpp @codyoss I've fixed the PR, so would you review it again? 🙏 |
BrennaEpp
reviewed
Feb 7, 2023
shuheiktgw
force-pushed
the
fix_gcs_amulator_with_credentials
branch
from
2fc38c1
to
8663de0
Compare
|
@tritone @BrennaEpp @codyoss Thank you for your review! I've fixed it, so would you review the PR again? |
tritone
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
tritone
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
tritone
approved these changes
Feb 14, 2023
tritone
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encountered the same problem with googleapis/google-api-go-client#558 when specifying
STORAGE_EMULATOR_HOST. For our case, we'd like to passoption.WithTokenSource, and it raises the following error withSTORAGE_EMULATOR_HOSTduring the test. To avoid the error, we should passinternaloption.SkipDialSettingsValidationas the Spanner client does.