Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): specify credentials with STORAGE_EMULATOR_HOST #7271

Merged
merged 5 commits into from
Feb 14, 2023

Conversation

shuheiktgw
Copy link
Contributor

Encountered the same problem with googleapis/google-api-go-client#558 when specifying STORAGE_EMULATOR_HOST. For our case, we'd like to pass option.WithTokenSource, and it raises the following error with STORAGE_EMULATOR_HOST during the test. To avoid the error, we should pass internaloption.SkipDialSettingsValidation as the Spanner client does.

options.WithoutAuthentication is incompatible with any option that provides credentials

@shuheiktgw shuheiktgw requested review from a team as code owners January 19, 2023 01:58
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the Cloud Storage API. labels Jan 19, 2023
@tritone tritone added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 19, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 19, 2023
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I think this looks good to me. @BrennaEpp or @codyoss any thoughts?

storage/storage_test.go Outdated Show resolved Hide resolved
@shuheiktgw
Copy link
Contributor Author

@tritone @BrennaEpp @codyoss I've fixed the PR, so would you review it again? 🙏

Copy link
Contributor

@BrennaEpp BrennaEpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion, otherwise looks good.

storage/storage_test.go Outdated Show resolved Hide resolved
@shuheiktgw shuheiktgw force-pushed the fix_gcs_amulator_with_credentials branch from 2fc38c1 to 8663de0 Compare February 7, 2023 23:40
@shuheiktgw
Copy link
Contributor Author

shuheiktgw commented Feb 7, 2023

@tritone @BrennaEpp @codyoss Thank you for your review! I've fixed it, so would you review the PR again?

@tritone tritone added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 8, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 8, 2023
@tritone tritone added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 14, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 14, 2023
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution!

@tritone tritone added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 14, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 14, 2023
@tritone tritone enabled auto-merge (squash) February 14, 2023 22:01
@tritone tritone merged commit 940ae15 into googleapis:main Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants