-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storage): export gRPC client constructor #8509
Conversation
This publicly exports the gRPC client constructor, making it possible to call directly rather than access via an environment variable. Also adds public docs about the gRPC API which is still in private preview, as well as basic instructions for DirectPath. Updates benchmarking script to call the new constructor directly as well.
|
||
If the application is running within GCP, users may get better performance by | ||
enabling DirectPath (enabling requests to skip load balancing steps). To enable, | ||
set the environment variable `GOOGLE_CLOUD_ENABLE_DIRECT_PATH_XDS=true` and add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this env variable shouldn't be needed anymore. Probably worth double checking the grpc release notes and your version to try and remove.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like this is still used to some extent inside the dial logic for go: https://github.com/googleapis/google-api-go-client/blob/62d88ff7c06b828324b3cf5fd004cdf75838f496/transport/grpc/dial.go#L241
I need to investigate how this actually works in practice...
This publicly exports the gRPC client constructor, making it possible to call directly rather than access via an environment variable.
Also adds public docs about the gRPC API which is still in private preview, as well as basic instructions for DirectPath.
Updates benchmarking script to call the new constructor directly as well.