Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

destination_name option for new client library #10734

Open
suztomo opened this issue Apr 23, 2024 · 4 comments
Open

destination_name option for new client library #10734

suztomo opened this issue Apr 23, 2024 · 4 comments
Assignees
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@suztomo
Copy link
Member

suztomo commented Apr 23, 2024

The GitHub Actions workflow for new client library (hermetic) does not have destination_name that sets the output directory.

image

It currently has 9 inputs. The maximum length is 10 https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#onworkflow_dispatchinputs.

@zhumin8 zhumin8 added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Apr 25, 2024
@blakeli0
Copy link
Contributor

Do we still need this option? java-{library_name} is basically the destination name. Also, once @JoeWang1127 completed the trigger, I think we can remove this Github action, in favor of manually adding a section to generation_config.yaml directly.

@suztomo
Copy link
Member Author

suztomo commented Apr 25, 2024

I didn't read them correctly. the destination_name is library_name now.

@diegomarquezp Would you update the document?

@suztomo
Copy link
Member Author

suztomo commented Apr 25, 2024

I think we can remove this Github action, in favor of manually adding a section to generation_config.yaml directly

I expect the GitHub Actions workflow to add a section generation_config.yaml.

@diegomarquezp
Copy link
Contributor

I didn't read them correctly. the destination_name is library_name now.

@diegomarquezp Would you update the document?

Hi @suztomo, we have an entry in the action's readme. Which other document should be updated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

4 participants