Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update new_client generation script's repo value for .repo_metadata.json #8849

Closed
lqiu96 opened this issue Nov 29, 2022 · 0 comments
Closed

Update new_client generation script's repo value for .repo_metadata.json #8849

lqiu96 opened this issue Nov 29, 2022 · 0 comments
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@lqiu96
Copy link
Contributor

lqiu96 commented Nov 29, 2022

The new_client.py generation script sets the repo value to be googleapis/java-{module} when it should be googleapis/google-cloud-java.

google-cloud-java/generation/new_client/new-client.py

Line 127 in 0f71f52

"repo": f"googleapis/{language}-{output_name}",

We can try hard-coding the value to be googleapis/google-cloud-java since modules generated with this script should be going into this repo.

From #8837 (comment)
@lqiu96 lqiu96 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Nov 29, 2022
@lqiu96 lqiu96 mentioned this issue Nov 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lqiu96 @meltsufin