Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

datastore: runQuery(stream mode) - use limit(n) logically #296

Closed
stephenplusplus opened this issue Nov 10, 2014 · 1 comment
Closed

datastore: runQuery(stream mode) - use limit(n) logically #296

stephenplusplus opened this issue Nov 10, 2014 · 1 comment
Assignees
@stephenplusplus
Labels
api: datastore Issues related to the Datastore API. 🚨 This issue needs some love. triage me I really want to be triaged.
Milestone
Datastore Stable

Comments

@stephenplusplus
Copy link
Contributor

As discussed offline, @stephenplusplus and I agree on the fact that it would be more intuitive if in a stream context, .limit() affects the total number of results returned from the stream.
@stephenplusplus stephenplusplus self-assigned this Nov 10, 2014
@stephenplusplus
Copy link
Contributor Author

#291 (comment)

stephenplusplus added a commit to stephenplusplus/gcloud-node that referenced this issue Nov 10, 2014
@stephenplusplus
datastore: runQuery(stream mode) - use limit(n) logically - fixes goo…
0e2bf8c 
…gleapis#296
ryanseys added a commit that referenced this issue Nov 11, 2014
@ryanseys
Merge pull request #297 from stephenplusplus/spp--datastore-stream-limit
46036ae 
datastore: runQuery(stream mode) - use limit(n) logically - fixes #296
@jgeewax jgeewax added api: datastore Issues related to the Datastore API. enhancement labels Feb 2, 2015
@jgeewax jgeewax added this to the Datastore Stable milestone Feb 2, 2015
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Apr 6, 2020
@sofisl sofisl mentioned this issue Oct 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this issue Oct 11, 2022
@yoshi-automation @callmehiphop
feat: .d.ts for protos (#296)
35ad462
@sofisl sofisl mentioned this issue Oct 12, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this issue Oct 12, 2022
@JustinBeckwith @bcoe
feat: bump release level to GA (#296)
148340e
sofisl pushed a commit that referenced this issue Oct 12, 2022
@release-please
chore: release 2.0.0 (#301)
554a43d 
🤖 I have created a release \*beep\* \*boop\* 
---
## [2.0.0](https://www.github.com/googleapis/nodejs-bigquery-data-transfer/compare/v1.5.3...v2.0.0) (2020-04-10)


### ⚠ BREAKING CHANGES

* The library now supports Node.js v10+. The last version to support Node.js v8 is tagged legacy-8 on NPM.
* move API to typescript code generation (#300)

### Features

* bump release level to GA ([#296](https://www.github.com/googleapis/nodejs-bigquery-data-transfer/issues/296)) ([8d1850a](https://www.github.com/googleapis/nodejs-bigquery-data-transfer/commit/8d1850ad542efb7d6f5ceac245f6e69c6f0550ed))
* deferred client initialization ([#321](https://www.github.com/googleapis/nodejs-bigquery-data-transfer/issues/321)) ([dc667b3](https://www.github.com/googleapis/nodejs-bigquery-data-transfer/commit/dc667b31d22796946bf94a01ece0cb60d083049c))
* drop node8 support, support for async iterators ([#335](https://www.github.com/googleapis/nodejs-bigquery-data-transfer/issues/335)) ([e9a9b24](https://www.github.com/googleapis/nodejs-bigquery-data-transfer/commit/e9a9b240159d9dd8e22e99bc733b5ff6a023b769))
* export protos in src/index.ts ([7426c53](https://www.github.com/googleapis/nodejs-bigquery-data-transfer/commit/7426c53e19b040c60b2c12267eb494b5db90b32a))
* move API to typescript code generation ([#300](https://www.github.com/googleapis/nodejs-bigquery-data-transfer/issues/300)) ([9094a74](https://www.github.com/googleapis/nodejs-bigquery-data-transfer/commit/9094a74364a8b1a19dff53926453d4a777d5fb21))
* use first party client oauth ([b687434](https://www.github.com/googleapis/nodejs-bigquery-data-transfer/commit/b687434b6f11e8f3539cc07b7bd8c8234211286a))


### Bug Fixes

* export explicit version from protos.js ([#339](https://www.github.com/googleapis/nodejs-bigquery-data-transfer/issues/339)) ([5ed9ed0](https://www.github.com/googleapis/nodejs-bigquery-data-transfer/commit/5ed9ed0117e697711098602a0c7270faa99eb9d5))
* pass x-goog-request-params header for streaming calls ([1af9266](https://www.github.com/googleapis/nodejs-bigquery-data-transfer/commit/1af926661ef293b920849562a9106799b212d793))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
sofisl pushed a commit that referenced this issue Oct 12, 2022
@yoshi-automation
chore: update github actions configuration (#296)
25d9d62 
This PR was generated using Autosynth. 🌈


<details><summary>Log from Synthtool</summary>

```
2020-03-22 04:43:17,512 synthtool > Executing /tmpfs/src/git/autosynth/working_repo/synth.py.
.eslintignore
.eslintrc.yml
.github/ISSUE_TEMPLATE/bug_report.md
.github/ISSUE_TEMPLATE/feature_request.md
.github/ISSUE_TEMPLATE/support_request.md
.github/PULL_REQUEST_TEMPLATE.md
.github/publish.yml
.github/release-please.yml
.github/workflows/ci.yaml
.kokoro/common.cfg
.kokoro/continuous/node10/common.cfg
.kokoro/continuous/node10/docs.cfg
.kokoro/continuous/node10/lint.cfg
.kokoro/continuous/node10/samples-test.cfg
.kokoro/continuous/node10/system-test.cfg
.kokoro/continuous/node10/test.cfg
.kokoro/continuous/node12/common.cfg
.kokoro/continuous/node12/test.cfg
.kokoro/continuous/node8/common.cfg
.kokoro/continuous/node8/test.cfg
.kokoro/docs.sh
.kokoro/lint.sh
.kokoro/presubmit/node10/common.cfg
.kokoro/presubmit/node10/docs.cfg
.kokoro/presubmit/node10/lint.cfg
.kokoro/presubmit/node10/samples-test.cfg
.kokoro/presubmit/node10/system-test.cfg
.kokoro/presubmit/node10/test.cfg
.kokoro/presubmit/node12/common.cfg
.kokoro/presubmit/node12/test.cfg
.kokoro/presubmit/node8/common.cfg
.kokoro/presubmit/node8/test.cfg
.kokoro/presubmit/windows/common.cfg
.kokoro/presubmit/windows/test.cfg
.kokoro/publish.sh
.kokoro/release/docs.cfg
.kokoro/release/docs.sh
.kokoro/release/publish.cfg
.kokoro/samples-test.sh
.kokoro/system-test.sh
.kokoro/test.bat
.kokoro/test.sh
.kokoro/trampoline.sh
.mocharc.js
.nycrc
.prettierignore
.prettierrc
CODE_OF_CONDUCT.md
CONTRIBUTING.md
LICENSE
README.md
codecov.yaml
renovate.json
samples/README.md
2020-03-22 04:43:18,291 synthtool > Wrote metadata to synth.metadata.

```
</details>
This was referenced Oct 12, 2022
Merged
Merged
sofisl pushed a commit that referenced this issue Oct 13, 2022
@renovate-bot
chore(deps): update dependency @types/node to v14 (#296)
96c9a7e 
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@types/node](https://togithub.com/DefinitelyTyped/DefinitelyTyped) | [`^12.0.0` -> `^14.0.0`](https://renovatebot.com/diffs/npm/@types%2fnode/12.20.13/14.17.0) | [![age](https://badges.renovateapi.com/packages/npm/@types%2fnode/14.17.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/@types%2fnode/14.17.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/@types%2fnode/14.17.0/compatibility-slim/12.20.13)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/@types%2fnode/14.17.0/confidence-slim/12.20.13)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: "after 9am and before 3pm" (UTC).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻️ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-phishing-protection).
@sofisl sofisl mentioned this issue Oct 13, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this issue Oct 13, 2022
@gcf-owl-bot
fix: preserve default values in x-goog-request-params header (#296)
b3ece57 
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 474338479

Source-Link: googleapis/googleapis@d5d35e0

Source-Link: googleapis/googleapis-gen@efcd3f9
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWZjZDNmOTM5NjJhMTAzZjY4ZjAwM2UyYTFlZWNkZTZmYTIxNmEyNyJ9
@release-please release-please bot mentioned this issue Oct 13, 2022
Closed
sofisl pushed a commit that referenced this issue Oct 13, 2022
@yoshi-automation @sofisl
feat: .d.ts for protos (#296)
b2d1c03
sofisl pushed a commit that referenced this issue Oct 13, 2022
@JustinBeckwith @sofisl
feat: bump release level to GA (#296)
92666a9
sofisl pushed a commit that referenced this issue Oct 13, 2022
@release-please @sofisl
chore: release 2.0.0 (#301)
b63ef07 
🤖 I have created a release \*beep\* \*boop\* 
---
## [2.0.0](https://www.github.com/googleapis/nodejs-bigquery-data-transfer/compare/v1.5.3...v2.0.0) (2020-04-10)


### ⚠ BREAKING CHANGES

* The library now supports Node.js v10+. The last version to support Node.js v8 is tagged legacy-8 on NPM.
* move API to typescript code generation (#300)

### Features

* bump release level to GA ([#296](https://www.github.com/googleapis/nodejs-bigquery-data-transfer/issues/296)) ([8d1850a](https://www.github.com/googleapis/nodejs-bigquery-data-transfer/commit/8d1850ad542efb7d6f5ceac245f6e69c6f0550ed))
* deferred client initialization ([#321](https://www.github.com/googleapis/nodejs-bigquery-data-transfer/issues/321)) ([dc667b3](https://www.github.com/googleapis/nodejs-bigquery-data-transfer/commit/dc667b31d22796946bf94a01ece0cb60d083049c))
* drop node8 support, support for async iterators ([#335](https://www.github.com/googleapis/nodejs-bigquery-data-transfer/issues/335)) ([e9a9b24](https://www.github.com/googleapis/nodejs-bigquery-data-transfer/commit/e9a9b240159d9dd8e22e99bc733b5ff6a023b769))
* export protos in src/index.ts ([7426c53](https://www.github.com/googleapis/nodejs-bigquery-data-transfer/commit/7426c53e19b040c60b2c12267eb494b5db90b32a))
* move API to typescript code generation ([#300](https://www.github.com/googleapis/nodejs-bigquery-data-transfer/issues/300)) ([9094a74](https://www.github.com/googleapis/nodejs-bigquery-data-transfer/commit/9094a74364a8b1a19dff53926453d4a777d5fb21))
* use first party client oauth ([b687434](https://www.github.com/googleapis/nodejs-bigquery-data-transfer/commit/b687434b6f11e8f3539cc07b7bd8c8234211286a))


### Bug Fixes

* export explicit version from protos.js ([#339](https://www.github.com/googleapis/nodejs-bigquery-data-transfer/issues/339)) ([5ed9ed0](https://www.github.com/googleapis/nodejs-bigquery-data-transfer/commit/5ed9ed0117e697711098602a0c7270faa99eb9d5))
* pass x-goog-request-params header for streaming calls ([1af9266](https://www.github.com/googleapis/nodejs-bigquery-data-transfer/commit/1af926661ef293b920849562a9106799b212d793))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
@sofisl sofisl mentioned this issue Nov 10, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this issue Nov 10, 2022
@release-please @bcoe
chore: release 2.0.1 (#296)
d957145
@sofisl sofisl mentioned this issue Nov 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this issue Nov 11, 2022
@release-please
chore: release 1.7.0 (#296)
54fc0d0 
🤖 I have created a release \*beep\* \*boop\* 
---
## [1.7.0](https://www.github.com/googleapis/nodejs-cloud-container/compare/v1.6.2...v1.7.0) (2020-03-06)


### Features

* deferred client initialization ([#304](https://www.github.com/googleapis/nodejs-cloud-container/issues/304)) ([b1b7080](https://www.github.com/googleapis/nodejs-cloud-container/commit/b1b70806289aea73a6e83d3d33983d05856f21f3))
* export protos in src/index.ts ([acaaeff](https://www.github.com/googleapis/nodejs-cloud-container/commit/acaaeff08ad5505accc15bb496bcd3a29086a5ac))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
sofisl pushed a commit that referenced this issue Nov 11, 2022
@gcf-owl-bot
fix(documentai): add ancillary service bindings to service_yaml (#296)
ce4fe16 
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 421098374

Source-Link: googleapis/googleapis@706ac2b

Source-Link: googleapis/googleapis-gen@d469765
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZDQ2OTc2NWJmMjE5NDc4MGE5MzNlMTViNGNlNmM1ZDFjNDc0MjQ4OSJ9
@sofisl sofisl mentioned this issue Nov 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this issue Nov 11, 2022
@renovate-bot
chore(deps): update dependency jsdoc-region-tag to v2 (#296)
a8df6c0 
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [jsdoc-region-tag](https://togithub.com/googleapis/jsdoc-region-tag) | [`^1.0.4` -> `^2.0.0`](https://renovatebot.com/diffs/npm/jsdoc-region-tag/1.3.1/2.0.0) | [![age](https://badges.renovateapi.com/packages/npm/jsdoc-region-tag/2.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/jsdoc-region-tag/2.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/jsdoc-region-tag/2.0.0/compatibility-slim/1.3.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/jsdoc-region-tag/2.0.0/confidence-slim/1.3.1)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/jsdoc-region-tag</summary>

### [`v2.0.0`](https://togithub.com/googleapis/jsdoc-region-tag/blob/HEAD/CHANGELOG.md#&#8203;200-httpsgithubcomgoogleapisjsdoc-region-tagcomparev131v200-2022-05-20)

[Compare Source](https://togithub.com/googleapis/jsdoc-region-tag/compare/v1.3.1...v2.0.0)

##### ⚠ BREAKING CHANGES

-   update library to use Node 12 ([#&#8203;107](https://togithub.com/googleapis/jsdoc-region-tag/issues/107))

##### Build System

-   update library to use Node 12 ([#&#8203;107](https://togithub.com/googleapis/jsdoc-region-tag/issues/107)) ([5b51796](https://togithub.com/googleapis/jsdoc-region-tag/commit/5b51796771984cf8b978990025f14faa03c19923))

##### [1.3.1](https://www.github.com/googleapis/jsdoc-region-tag/compare/v1.3.0...v1.3.1) (2021-08-11)

##### Bug Fixes

-   **build:** migrate to using main branch ([#&#8203;79](https://www.togithub.com/googleapis/jsdoc-region-tag/issues/79)) ([5050615](https://www.github.com/googleapis/jsdoc-region-tag/commit/50506150b7758592df5e389c6a5c3d82b3b20881))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 9am and before 3pm" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-dialogflow-cx).
sofisl pushed a commit that referenced this issue Nov 16, 2022
@release-please
chore: release 2.1.4 (#296)
74f4e01 
🤖 I have created a release \*beep\* \*boop\*
---
### [2.1.4](https://www.github.com/googleapis/nodejs-recaptcha-enterprise/compare/v2.1.3...v2.1.4) (2021-06-30)


### Bug Fixes

* **deps:** google-gax v2.17.0 with mTLS ([#294](https://www.github.com/googleapis/nodejs-recaptcha-enterprise/issues/294)) ([45c12e5](https://www.github.com/googleapis/nodejs-recaptcha-enterprise/commit/45c12e5a7f9dbb40f054f7a4d9da0477010f6b00))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@sofisl sofisl mentioned this issue Nov 16, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this issue Nov 17, 2022
@renovate @JustinBeckwith
fix(deps): update dependency @google-cloud/promisify to v1 (#296)
8c3ce3f
@sofisl sofisl mentioned this issue Nov 17, 2022
Merged
4 tasks
@sofisl sofisl mentioned this issue Jan 17, 2023
Merged
4 tasks
sofisl pushed a commit that referenced this issue Jan 17, 2023
@yoshi-automation @jkwlui
BREAKING: rename method imagePath => referenceImagePath (#296)
5dbf98d 
* [CHANGE ME] Re-generated  to pick up changes in the API or client library generator.

* rename imagePath => referenceImagePath in samples
sofisl pushed a commit that referenced this issue Jan 24, 2023
@jkwlui @callmehiphop
chore: move CONTRIBUTING.md to root (#296)
c6d7369
sofisl pushed a commit that referenced this issue Jan 25, 2023
@jkwlui @callmehiphop
chore: move CONTRIBUTING.md to root (#296)
8f6b20b
@takeratta takeratta mentioned this issue Jul 6, 2023
Open
sofisl pushed a commit that referenced this issue Sep 14, 2023
@renovate-bot @callmehiphop
fix(deps): update dependency dns-zonefile to v0.2.3 (#296)
86c99b4
@sofisl sofisl mentioned this issue Sep 14, 2023
Merged
4 tasks
This was referenced Oct 27, 2023
Open
Open
Open
@takeratta takeratta mentioned this issue Nov 28, 2023
Open
This was referenced Dec 14, 2023
Open
Open
Open
This was referenced Jan 2, 2024
Open
Open
Open
Open
Open
This was referenced Mar 15, 2024
Open
Open
Open
@takeratta takeratta mentioned this issue May 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephenplusplus stephenplusplus

Labels
api: datastore Issues related to the Datastore API. 🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Milestone
Datastore Stable
Development

No branches or pull requests
3 participants
@jgeewax @stephenplusplus @yoshi-automation