feat(storage): add support for soft delete #25340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: storage
bajajneha27
force-pushed
the
b/324502549
branch
2 times, most recently
from
eab9373
to
edd38d5
Compare
|
The acceptance test failures are not related to this PR. I'll fix them in separate PR. |
SandeepTuniki
approved these changes
Apr 3, 2024
google-cloud-storage/test/helper.rb
Outdated
| enable_object_retention: nil | ||
| enable_object_retention: nil, | ||
| effective_time: DateTime.now, | ||
| retention_duration_seconds: 604800 |
There was a problem hiding this comment.
I'm assuming this number indicates a 7 day retention period? Maybe append a comment like you did for acceptance tests:
retention_duration_seconds: 604800 # 7 days
google-cloud-storage/test/helper.rb
Outdated
| }.delete_if { |_, v| v.nil? } | ||
| end | ||
|
|
||
| def soft_delete_policy_object retention_duration_seconds: 604800 |
There was a problem hiding this comment.
Same comment as mentioned previously about documenting it as 7 days.
JesseLovelace
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for soft delete.
The operations we need are:
closes: #24793