Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the "scope" param of launchInBrowser function in dailymotion sample is not used. #39

Closed
wonderfly opened this issue Jan 9, 2015 · 4 comments
Assignees
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@wonderfly
Copy link
Contributor

From me@sunchangming.com on May 16, 2012 22:53:54

Version of google-oauth-java-client (e.g. 1.5.0-beta)? trunk Java environment (e.g. Java 6, Android 2.3, App Engine)? java 6 Describe the problem. package: com.google.api.services.samples.dailymotion.cmd
file: lineDailyMotionSample.java
private static void launchInBrowser(
String browser, String redirectUrl, String clientId, String scope) throws IOException {
String authorizationUrl = new AuthorizationCodeRequestUrl(
AUTHORIZATION_SERVER_URL, clientId).setRedirectUri(redirectUrl).build();
if (Desktop.isDesktopSupported()) {
Desktop desktop = Desktop.getDesktop();
if (desktop.isSupported(Action.BROWSE)) {
desktop.browse(URI.create(authorizationUrl));
return;
}
}
if (browser != null) {
Runtime.getRuntime().exec(new String[] {browser, authorizationUrl});
} else {
System.out.println("Open the following address in your favorite browser:");
System.out.println(" " + authorizationUrl);
}
}

Scope is not passed to redirect url. How would you expect it to be fixed? String authorizationUrl = new AuthorizationCodeRequestUrl(
AUTHORIZATION_SERVER_URL, clientId).setRedirectUri(redirectUrl).setScopes(scope).build();

Or, please remove this param.

Original issue: http://code.google.com/p/google-oauth-java-client/issues/detail?id=39

@wonderfly wonderfly added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. imported priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Jan 9, 2015
@wonderfly wonderfly self-assigned this Jan 9, 2015
@wonderfly
Copy link
Contributor Author

From rmis...@google.com on May 17, 2012 03:49:35

Labels: Milestone-Version1.10.0

@wonderfly
Copy link
Contributor Author

From rmis...@google.com on May 31, 2012 10:36:52

http://codereview.appspot.com/6247063/

Status: Fixed

@wonderfly
Copy link
Contributor Author

From rmis...@google.com on May 31, 2012 10:37:00

Status: Started

@wonderfly
Copy link
Contributor Author

From rmis...@google.com on June 06, 2012 05:55:14

Status: Fixed

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

2 participants