Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: executeSelect now use provided credentials instead of GOOGLE_APP… #3465

Merged
merged 2 commits into from
Aug 29, 2024
Merged

fix: executeSelect now use provided credentials instead of GOOGLE_APP… #3465

merged 2 commits into from
Aug 29, 2024

Conversation

PhongChuong
Copy link
Contributor

@PhongChuong PhongChuong commented Aug 29, 2024 •
edited
Loading

…LICATION_CREDENTIALS

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2531, #2234 ☕️

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/java-bigquery API. labels Aug 29, 2024
@PhongChuong PhongChuong marked this pull request as ready for review August 29, 2024 17:51
@PhongChuong PhongChuong requested a review from a team as a code owner August 29, 2024 17:51
shollyman
shollyman approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor question about how the credentials are propagated, otherwise LGTM

google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/ConnectionImpl.java Show resolved Hide resolved
@PhongChuong PhongChuong added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 29, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 29, 2024
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner August 29, 2024 19:03
@PhongChuong PhongChuong added the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 29, 2024
@PhongChuong
Copy link
Contributor Author

Thanks for the review.

@PhongChuong PhongChuong merged commit cd82235 into main Aug 29, 2024
20 checks passed
@PhongChuong PhongChuong deleted the i2531 branch August 29, 2024 19:26
@release-please release-please bot mentioned this pull request Aug 29, 2024
Merged
This was referenced Sep 5, 2024
Closed
Closed
Closed
@shollyman shollyman mentioned this pull request Sep 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shollyman shollyman shollyman approved these changes

@tswast tswast Awaiting requested review from tswast tswast is a code owner automatically assigned from googleapis/api-bigquery

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/java-bigquery API. kokoro:run Add this label to force Kokoro to re-run the tests. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
2 participants
@PhongChuong @shollyman