-
Notifications
You must be signed in to change notification settings - Fork 10
Conversation
Warning: This pull request is touching the following templated files:
|
CLIRR is failing with removed classes. "beta" marked version is ok to have breaking changes. Would you confirm this intentional? (The CL messages would reveal that)
|
It's not a new failure. You can see the same in main branch: https://github.com/googleapis/java-iam/actions/runs/3026401708/jobs/4869759373. |
Thank you for checking. ci / dependencies (8) failed.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Let's get the checks green.
proto-google-iam-v2beta/pom.xml
Outdated
<dependency> | ||
<groupId>com.google.api.grpc</groupId> | ||
<artifactId>proto-google-iam-v1</artifactId> | ||
</dependency> | ||
<dependency> | ||
<groupId>com.google.api</groupId> | ||
<artifactId>api-common</artifactId> | ||
</dependency> | ||
<dependency> | ||
<groupId>com.google.guava</groupId> | ||
<artifactId>guava</artifactId> | ||
</dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong module?
[INFO] --- maven-dependency-plugin:3.3.0:analyze (default-cli) @ proto-google-iam-v2beta ---
Warning: Unused declared dependencies found:
Warning: com.google.api.grpc:proto-google-iam-v1:jar:1.5.3-SNAPSHOT:compile
Warning: com.google.api:api-common:jar:2.2.1:compile
Warning: com.google.guava:guava:jar:31.1-jre:compile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah didn't notice that! Thanks!
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
The commit are broken down to make it clear which parts are autogenerated and which parts had to be manually edited.