-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for batching configuration #977
Conversation
…-logging-logback into losalex/feat-903
…-logging-logback into losalex/feat-903
…-logging-logback into losalex/feat-903
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest to avoid introducing more dependencies or stream-like initialization.
The code will be cleaner if the configuration hides implementation details i.e. typing or GAX dependencies.
Is the only problem using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Talked offline - opened 1247 to implement batch settings abstraction layer in |
Fixes #903 ☕️