Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix dependency declaration to properly include runtime scope #1238

Merged
merged 2 commits into from
Aug 5, 2022

Conversation

BenWhitehead
Copy link
Contributor

Change the scope of the following dependencies to runtime from test

  • io.grpc:grpc-stub
  • io.grpc:grpc-core
  • com.google.http-client:google-http-client

Change the scope of the following dependencies to runtime from test
* io.grpc:grpc-stub
* io.grpc:grpc-core
* com.google.http-client:google-http-client
@BenWhitehead BenWhitehead requested review from a team as code owners August 5, 2022 18:30
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: pubsub Issues related to the googleapis/java-pubsub API. labels Aug 5, 2022
@suztomo
Copy link
Member

suztomo commented Aug 5, 2022

Would you also remove the version for maven-dependency-plugin? It's already set in the java-shared-config:

https://github.com/googleapis/java-shared-config/blob/main/pom.xml#L200

(We didn't need to have the problematic pull request first of all)

@BenWhitehead
Copy link
Contributor Author

Removed, rebuilding now

@BenWhitehead BenWhitehead merged commit e9a4ce5 into main Aug 5, 2022
@BenWhitehead BenWhitehead deleted the fix-dep-scope branch August 5, 2022 19:13
@alicejli
Copy link
Contributor

alicejli commented Aug 5, 2022

Confirmed this fix works and makes google-http-client show up as a dependency in the flattened pom of /home/alicejli/.m2/repository/com/google/cloud/google-cloud-pubsub/1.120.11-SNAPSHOT after mvn install.

image

gcf-merge-on-green bot pushed a commit that referenced this pull request Aug 6, 2022
🤖 I have created a release *beep* *boop*
---


## [1.120.11](v1.120.10...v1.120.11) (2022-08-06)


### Bug Fixes

* fix dependency declaration to properly include runtime scope ([#1238](#1238)) ([e9a4ce5](e9a4ce5))


### Dependencies

* update dependency com.google.cloud:google-cloud-bigquery to v2.14.2 ([#1235](#1235)) ([e2af6c3](e2af6c3))
* update dependency com.google.cloud:google-cloud-bigquery to v2.14.3 ([#1236](#1236)) ([399e8d7](399e8d7))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/java-pubsub API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants