-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Proto Columns support in JDBC #1252
Merged
harshachinta
merged 28 commits into
googleapis:main
from
harshachinta:proto-column-feature
May 28, 2024
Merged
feat: add Proto Columns support in JDBC #1252
harshachinta
merged 28 commits into
googleapis:main
from
harshachinta:proto-column-feature
May 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for Proto columns
product-auto-label
bot
added
size: xl
Pull request size is extra large.
api: spanner
Issues related to the googleapis/java-spanner-jdbc API.
labels
Jun 6, 2023
olavloite
reviewed
Jun 6, 2023
src/main/java/com/google/cloud/spanner/jdbc/AbstractJdbcWrapper.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/cloud/spanner/jdbc/JdbcParameterStore.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/cloud/spanner/jdbc/JdbcTypeConverter.java
Outdated
Show resolved
Hide resolved
harshachinta
added
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
Jun 6, 2023
olavloite
approved these changes
Jun 9, 2023
src/main/java/com/google/cloud/spanner/jdbc/JdbcTypeConverter.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/cloud/spanner/jdbc/JdbcTypeConverter.java
Outdated
Show resolved
Hide resolved
harshachinta
changed the title
feat: support Proto Columns
feat: add Proto Columns support in JDBC
May 25, 2024
harshachinta
added
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
and removed
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
labels
May 27, 2024
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
May 27, 2024
harshachinta
added
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
May 27, 2024
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
May 27, 2024
olavloite
reviewed
May 28, 2024
src/main/java/com/google/cloud/spanner/jdbc/JdbcTypeConverter.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/cloud/spanner/jdbc/JdbcTypeConverter.java
Outdated
Show resolved
Hide resolved
src/test/java/com/google/cloud/spanner/jdbc/it/ITProtoColumnsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/google/cloud/spanner/jdbc/it/ITProtoColumnsTest.java
Outdated
Show resolved
Hide resolved
harshachinta
added
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
May 28, 2024
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
May 28, 2024
olavloite
approved these changes
May 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: spanner
Issues related to the googleapis/java-spanner-jdbc API.
size: xl
Pull request size is extra large.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Proto Columns datatype.