Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pipe metadata along #1178

Merged
merged 21 commits into from
Jan 27, 2023
Merged

fix: pipe metadata along #1178

Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
199eaf3
pipe metadata along
danieljbruce Sep 23, 2022
6b468bd
Arrange imports back to where they were
danieljbruce Sep 23, 2022
495f592
revert some automatic imports
danieljbruce Sep 23, 2022
6990013
revert automatic import
danieljbruce Sep 23, 2022
8f52f78
Merge branch 'main' into metadata-bubble-up
danieljbruce Sep 26, 2022
38a271a
report metadata when it doesn’t exist yet
danieljbruce Sep 26, 2022
ae3f3b3
Merge branch 'main' into metadata-bubble-up
danieljbruce Sep 26, 2022
618131d
should include metadata in result
danieljbruce Sep 26, 2022
76e500b
Merge branch 'metadata-bubble-up' of https://github.com/danieljbruce/…
danieljbruce Sep 26, 2022
98ad951
Merge branch 'main' into metadata-bubble-up
danieljbruce Sep 26, 2022
af8b00d
Remove only
danieljbruce Sep 26, 2022
64ea31c
Merge branch 'metadata-bubble-up' of https://github.com/danieljbruce/…
danieljbruce Sep 26, 2022
9efbb28
Removed setting metadata that is no longer used
danieljbruce Sep 27, 2022
2b9e422
Add an assert fail
danieljbruce Sep 27, 2022
592e653
Better check for metadata
danieljbruce Sep 27, 2022
f3c98b5
use bind instead
danieljbruce Sep 27, 2022
daac5c8
revert changes for exposing metadata directly
danieljbruce Sep 28, 2022
166136d
change stream emit metadata back
danieljbruce Sep 28, 2022
4a892c0
Merge branch 'main' into metadata-bubble-up
danieljbruce Jan 11, 2023
6c9a561
Merge branch 'main' into metadata-bubble-up
danieljbruce Jan 27, 2023
9b9768c
Merge branch 'main' into metadata-bubble-up
danieljbruce Jan 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -863,6 +863,7 @@ export class Bigtable {
gaxStream = requestFn!();
gaxStream
.on('error', stream.destroy.bind(stream))
.on('metadata', stream.emit.bind(stream, 'metadata'))
.on('request', stream.emit.bind(stream, 'request'))
.pipe(stream);
});
Expand All @@ -879,6 +880,9 @@ export class Bigtable {
.on('error', (err: Error) => {
stream.destroy(err);
})
.on('metadata', metadata => {
stream.emit('metadata', metadata);
})
.on('response', response => {
stream.emit('response', response);
})
Expand Down