-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: safe integer bounds conversion #576
fix: safe integer bounds conversion #576
Conversation
Codecov Report
@@ Coverage Diff @@
## master #576 +/- ##
==========================================
+ Coverage 86.77% 86.82% +0.05%
==========================================
Files 33 33
Lines 1981 1981
Branches 349 349
==========================================
+ Hits 1719 1720 +1
Misses 233 233
+ Partials 29 28 -1
Continue to review full report at Codecov.
|
@laljikanjareeya could you please also add a unit test(s) where |
9ea1625
to
135c610
Compare
@AVaksman Added more unit tests for outside of bounds. |
LGTM |
Instead of checking
MIN_SAFE_INTEGER
andMAX_SAFE_INTEGER
condition, Added embedded functionNumber.isSafeInteger
to check safe integer.Fixes #575