Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

fix: Specify build as the body of a CreateBuild call. The Cloud Build API has always assumed this, but now we are actually specifying it. #202

Merged
merged 2 commits into from
Mar 30, 2021

Conversation

yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/401e1768-7aec-4430-ad3d-b196a5d032e0/targets

  • To automatically regenerate this PR, check this box.

PiperOrigin-RevId: 363244566
Source-Link: googleapis/googleapis@913f555

…uild API has always assumed this, but now we are actually specifying it.

feat: Add `ReceiveTriggerWebhook` for webhooks activating specific triggers.

docs: Update field docs on required-ness behavior and fix typos.

docs: Add `$PROJECT_NUMBER` as a substitution variable.

feat: Add `SecretManager`-related resources and messages for corresponding integration.

docs: Clarify lifetime/expiration behavior around `ListBuilds` page tokens.

feat: Add `COMMENTS_ENABLED_FOR_EXTERNAL_CONTRIBUTORS_ONLY` for corresponding comment control behavior with triggered builds.

feat: Add `E2_HIGHCPU_8` and `E2_HIGHCPU_32` machine types.

Committer: @LOZORD
PiperOrigin-RevId: 363244566

Source-Author: Google APIs <noreply@google.com>
Source-Date: Tue Mar 16 12:32:12 2021 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 913f5553d5ff5940cddd8245313136449b2a3571
Source-Link: googleapis/googleapis@913f555
@yoshi-automation yoshi-automation requested review from a team as code owners March 17, 2021 08:21
@product-auto-label product-auto-label bot added the api: cloudbuild Issues related to the googleapis/nodejs-cloudbuild API. label Mar 17, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 17, 2021
@codecov
Copy link

codecov bot commented Mar 17, 2021

Codecov Report

Merging #202 (a2caee2) into master (bfad35c) will increase coverage by 0.15%.
The diff coverage is 99.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #202      +/-   ##
==========================================
+ Coverage   97.84%   97.99%   +0.15%     
==========================================
  Files           5        5              
  Lines        2639     2897     +258     
  Branches      102      107       +5     
==========================================
+ Hits         2582     2839     +257     
- Misses         56       57       +1     
  Partials        1        1              
Impacted Files Coverage Δ
src/v1/cloud_build_client.ts 98.75% <99.61%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfad35c...a2caee2. Read the comment docs.

@askmeegs
Copy link
Contributor

The npm install command in ci / test (15) is failing:

Run npm install --production --engine-strict --ignore-scripts --no-package-lock
npm ERR! code ERR_SOCKET_TIMEOUT
npm ERR! errno ERR_SOCKET_TIMEOUT
npm ERR! request to https://registry.npmjs.org/yargs failed, reason: Socket timeout

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/runner/.npm/_logs/2021-03-23T18_17_26_543Z-debug.log
Error: Process completed with exit code 1.

@bcoe
Copy link
Contributor

bcoe commented Mar 30, 2021

@askmeegs looks like this was a temporary issue with actions perhaps? If that ever happens to you, you can click details for the given action, and click "Re-run Jobs" -- if it does happen to be an intermittent failure, this will often solve the issue.

@bcoe bcoe merged commit 48fe15d into master Mar 30, 2021
@bcoe bcoe deleted the autosynth-googleapis branch March 30, 2021 19:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: cloudbuild Issues related to the googleapis/nodejs-cloudbuild API. cla: yes This human has signed the Contributor License Agreement. context: full
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants