fix: handle ignoreUndefinedProperties in set(merge: true) #1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilhuff
added
the
api: firestore
google-cla
bot
added
the
cla: yes
wilhuff
force-pushed
the
wilhuff/ignore-undefined-fix
branch
from
966bf92
to
6e40aee
Compare
Codecov Report
@@ Coverage Diff @@
## master #1396 +/- ##
=======================================
Coverage 98.51% 98.51%
=======================================
Files 32 32
Lines 19374 19378 +4
Branches 1273 1360 +87
=======================================
+ Hits 19086 19090 +4
Misses 284 284
Partials 4 4
Continue to review full report at Codecov.
|
schmidt-sebastian
approved these changes
Jan 26, 2021
dev/src/document.ts
Outdated
| // If the value is undefined it can never participate in the document | ||
| // mask. With ignoreUndefinedProperties set to true, this shouldn't | ||
| // affect the document mask. With ignoreUndefinedProperties set to | ||
| // false, we'll throw an error when trying to create a proto from the |
There was a problem hiding this comment.
Nit: This error is thrown first by validateDocumentData: "Cannot use "undefined" as a Firestore value (found in field "bar"). If you want to ignore undefined values, enable ignoreUndefinedProperties."
Previously any field in the document would be propagated into the DocumentMask regardless of whether or not it had an undefined value, which led to the client acting as if the user had passed `FieldValue.delete()`, which wasn't intended.
wilhuff
force-pushed
the
wilhuff/ignore-undefined-fix
branch
from
6e40aee
to
a72cc82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously any field in the document would be propagated into the DocumentMask regardless of whether or not it had an undefined value, which led to the client acting as if the user had passed
FieldValue.delete(), which wasn't intended.Fixes #1392