feat: better support installed app client IDs #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…talled app client IDs and use ephemeral ports when possible
bcoe
approved these changes
Jun 20, 2022
bcoe
changed the title
gcf-owl-bot
bot
removed
the
owlbot:run
bcoe
added
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
|
@sqrrrl thank you for the contribution. |
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jun 20, 2022
🤖 I have created a release *beep* *boop* --- ## [2.1.0](v2.0.0...v2.1.0) (2022-06-20) ### Features * Relax expectations around redirect URL and port to better support installed app client IDs and use ephemeral ports when possible ([#141](#141)) ([5948e33](5948e33)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to better supports the installed app client types & use ephemeral ports for installed app clients. This also relaxes the path requirements for the redirectURL -- rather than require people conform to the expectations of the library, the library conforms to the redirectURL as specified by the developer for ports/paths.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #125 🦕