Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

feat!: drop node8 support, support for async iterators #396

Merged
merged 3 commits into from
Mar 31, 2020

Conversation

alexander-fenster
Copy link
Contributor

BREAKING CHANGE: The library now supports Node.js v10+. The last version to support Node.js v8 is tagged legacy-8 on NPM.

New feature: methods with pagination now support async iteration.

BREAKING CHANGE: The library now supports Node.js v10+. The last version to support Node.js v8 is tagged legacy-8 on NPM.

New feature: methods with pagination now support async iteration.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 31, 2020
@codecov
Copy link

codecov bot commented Mar 31, 2020

Codecov Report

Merging #396 into master will increase coverage by 21.39%.
The diff coverage is 98.8%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #396       +/-   ##
===========================================
+ Coverage   77.16%   98.55%   +21.39%     
===========================================
  Files           8        8               
  Lines       14912    16040     +1128     
  Branches      323      392       +69     
===========================================
+ Hits        11507    15809     +4302     
+ Misses       3399      225     -3174     
  Partials        6        6
Impacted Files Coverage Δ
src/v3/index.ts 100% <100%> (ø) ⬆️
src/v3/uptime_check_service_client.ts 98.45% <98.63%> (+22.51%) ⬆️
src/v3/group_service_client.ts 98.49% <98.65%> (+22.16%) ⬆️
src/v3/metric_service_client.ts 98.66% <98.7%> (+22.06%) ⬆️
src/v3/alert_policy_service_client.ts 98.51% <98.86%> (+23.64%) ⬆️
src/v3/service_monitoring_service_client.ts 98.54% <98.92%> (+20.03%) ⬆️
src/v3/notification_channel_service_client.ts 98.6% <98.99%> (+19.2%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10c4eea...73b199a. Read the comment docs.

@xiaozhenliu-gg5 xiaozhenliu-gg5 added the automerge Merge the pull request once unit tests and other checks pass. label Mar 31, 2020
@AVaksman
Copy link

@googlebot I consent.

@gcf-merge-on-green gcf-merge-on-green bot merged commit d65e8fb into master Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants