Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

what's the frequency of update of the proto files corpus? #340

Closed
proppy opened this issue Apr 15, 2021 · 5 comments
Closed

what's the frequency of update of the proto files corpus? #340

proppy opened this issue Apr 15, 2021 · 5 comments
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@proppy
Copy link

proppy commented Apr 15, 2021

It seems that the latest version (2.4.0) is not in sync with https://github.com/googleapis/googleapis

See below:

🍊 (cd googleapis && git log -1 --oneline)
9a9e29627 (HEAD -> master, origin/master, origin/HEAD) feat: Add fields for Pub/Sub triggers
🍡 cat node_modules/google-proto-files/package.json  | grep version
  "version": "2.4.0",
🍊 diff -Nru node_modules/google-proto-files/google/home/graph/v1/homegraph.proto googleapis/google/home/graph/v1/homegraph.proto 
--- node_modules/google-proto-files/google/home/graph/v1/homegraph.proto	1985-10-26 17:15:00.000000000 +0900
+++ googleapis/google/home/graph/v1/homegraph.proto	2021-04-15 21:45:00.313406274 +0900
@@ -194,10 +194,11 @@
   // Required. Third-party user ID.
   string agent_user_id = 2 [(google.api.field_behavior) = REQUIRED];
 
-  // Token to maintain state in the follow up notification response.
-  // Deprecated. See the [notifications
-  // guide](https://developers.google.com/assistant/smarthome/develop/notifications)
-  // for details on implementing follow up notifications.
+  // Deprecated.
+  // (-- Token to maintain state in the follow up notification response. See the
+  // notifications guide at
+  // https://developers.google.com/assistant/smarthome/develop/notifications for
+  // details on implementing follow up notifications --)
   string follow_up_token = 5 [deprecated = true];
 
   // Required. State of devices to update and notification metadata for devices.
👺 

Should we clarify the frequency of update in the README.md file?

@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Apr 17, 2021
@alexander-fenster
Copy link
Contributor

It's indeed not in sync. We do update it as needed.

@proppy Can you share your use case with this package? Is there any specific reason why you're using it and not the @google-cloud/* client libraries (that also have protos included)?

@alexander-fenster alexander-fenster added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. and removed 🚨 This issue needs some love. triage me I really want to be triaged. labels Jul 9, 2021
@alexander-fenster
Copy link
Contributor

@summer-ji-eng Let's schedule some time to update the protos in this package.

@proppy
Copy link
Author

proppy commented Jul 11, 2021

@alexander-fenster as it also includes non-cloud APIs (like https://source.corp.google.com/piper///depot/google3/google/home/graph/v1/homegraph.proto), it's possibly used by developers willing to gain enhanced performance/optimize resource consumption over the generic Node.js client: https://github.com/googleapis/google-auth-library-nodejs

See https://stackoverflow.com/questions/67113632/how-to-call-the-home-graph-api-with-grpc-on-node-js

@hkdevandla
Copy link
Member

did we update the protos @alexander-fenster @summer-ji-eng ? what are the next steps here?

@alexander-fenster
Copy link
Contributor

We did it two days ago, the latest release 2.5.0 contains the recent protos. @summer-ji-eng We need to setup a process of regular proto updates, maybe monthly will work. In the normal case, it's just an empty feat: PR (git checkout -b update && git commit --allow-empty -m 'feat: update protos' && git push origin update) and then a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

4 participants