Skip to content

Commit

Permalink
fix: update regex to target correct comment (#646)
Browse files Browse the repository at this point in the history
  • Loading branch information
callmehiphop authored Jun 7, 2019
1 parent cd54630 commit 9e8f245
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 16 deletions.
8 changes: 2 additions & 6 deletions samples/subscriptions.js
Original file line number Diff line number Diff line change
Expand Up @@ -119,9 +119,7 @@ async function createFlowControlledSubscription(
autoCreate: true,
});
console.log(
`Subscription ${
newSubscription.name
} created with a maximum of ${maxInProgress} unprocessed messages.`
`Subscription ${newSubscription.name} created with a maximum of ${maxInProgress} unprocessed messages.`
);

// [END pubsub_subscriber_flow_settings]
Expand Down Expand Up @@ -340,9 +338,7 @@ async function synchronousPull(projectName, subscriptionName) {
await client.modifyAckDeadline(modifyAckRequest);

console.log(
`Reset ack deadline for "${
message.message.data
}" for ${newAckDeadlineSeconds}s.`
`Reset ack deadline for "${message.message.data}" for ${newAckDeadlineSeconds}s.`
);
}
}
Expand Down
8 changes: 2 additions & 6 deletions samples/system-test/topics.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -163,9 +163,7 @@ describe('topics', () => {
.get({autoCreate: true});
const startTime = Date.now();
execSync(
`${cmd} publish-batch ${topicNameOne} "${
expectedMessage.data
}" -w ${waitTime}`
`${cmd} publish-batch ${topicNameOne} "${expectedMessage.data}" -w ${waitTime}`
);

const {data, publishTime} = await _pullOneMessage(subscription);
Expand All @@ -181,9 +179,7 @@ describe('topics', () => {
.subscription(subscriptionNameFour)
.get({autoCreate: true});
execSync(
`${cmd} publish-retry ${projectId} ${topicNameOne} "${
expectedMessage.data
}"`
`${cmd} publish-retry ${projectId} ${topicNameOne} "${expectedMessage.data}"`
);
const receivedMessage = await _pullOneMessage(subscription);
assert.strictEqual(receivedMessage.data.toString(), expectedMessage.data);
Expand Down
4 changes: 1 addition & 3 deletions src/message-queues.ts
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,7 @@ export class BatchError extends Error implements ServiceError {
metadata?: Metadata;
constructor(err: ServiceError, ackIds: string[], rpc: string) {
super(
`Failed to "${rpc}" for ${ackIds.length} message(s). Reason: ${
err.message
}`
`Failed to "${rpc}" for ${ackIds.length} message(s). Reason: ${err.message}`
);

this.ackIds = ackIds;
Expand Down
2 changes: 1 addition & 1 deletion synth.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

# https://github.com/googleapis/gapic-generator/issues/2127
s.replace("src/v1/subscriber_client.js",
" }\n\s*/\*\*\n\s+\* The DNS address for this API service.",
" }\n\s*/\*\*\n\s+\* The DNS address for this API service\.",
"\n // note: editing generated code\n"
" this.waitForReady = function(deadline, callback) {\n"
" return subscriberStub.then(\n"
Expand Down

0 comments on commit 9e8f245

Please sign in to comment.