Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct STORAGE_EMULATOR_HOST handling (#2069, #1314) #2070

Merged
merged 3 commits into from
Oct 18, 2022

Conversation

mgabeler-lee-6rs
Copy link
Contributor

credit to @jpambrun for identifying the fix

Test assertions needed to change slightly since they were asserting the
presence of functionality that doesn't actually work, specifically allowing
one to change the base url to not have /storage/v1. The code fundamentally
does not support this at all, and is full of places that are hard coded to
always include that path element. The code does support having a base path
before that however, and so that is what I updated the tests to check.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1314
Fixes #2069

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the googleapis/nodejs-storage API. labels Sep 20, 2022
@shaffeeullah shaffeeullah self-assigned this Sep 20, 2022
Copy link
Contributor

@danielbankhead danielbankhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - one minor, optional suggestion.

We have a code freeze for the next few weeks - will merge this after 🙂

src/storage.ts Outdated Show resolved Hide resolved
@shaffeeullah shaffeeullah added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 5, 2022
Co-authored-by: Daniel Bankhead <dan@danielbankhead.com>
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 5, 2022
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 18, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 18, 2022
@ddelgrosso1 ddelgrosso1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 18, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 18, 2022
@ddelgrosso1 ddelgrosso1 added the cla: yes This human has signed the Contributor License Agreement. label Oct 18, 2022
@ddelgrosso1 ddelgrosso1 merged commit c75b8b8 into googleapis:main Oct 18, 2022
danielbankhead added a commit that referenced this pull request Oct 19, 2022
shaffeeullah pushed a commit that referenced this pull request Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/nodejs-storage API. cla: yes This human has signed the Contributor License Agreement. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

STORAGE_EMULATOR_HOST not handled correctly baseurl is not quite right when using STORAGE_EMULATOR_HOST
5 participants