-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correct STORAGE_EMULATOR_HOST handling (#2069, #1314) #2070
Merged
ddelgrosso1
merged 3 commits into
googleapis:main
from
mgabeler-lee-6rs:fix/emulator-host
Oct 18, 2022
Merged
fix: correct STORAGE_EMULATOR_HOST handling (#2069, #1314) #2070
ddelgrosso1
merged 3 commits into
googleapis:main
from
mgabeler-lee-6rs:fix/emulator-host
Oct 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
Pull request size is small.
api: storage
Issues related to the googleapis/nodejs-storage API.
labels
Sep 20, 2022
danielbankhead
approved these changes
Oct 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - one minor, optional suggestion.
We have a code freeze for the next few weeks - will merge this after 🙂
shaffeeullah
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Oct 5, 2022
Co-authored-by: Daniel Bankhead <dan@danielbankhead.com>
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Oct 5, 2022
danielbankhead
approved these changes
Oct 5, 2022
ddelgrosso1
added
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Oct 18, 2022
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Oct 18, 2022
ddelgrosso1
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Oct 18, 2022
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Oct 18, 2022
ddelgrosso1
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Oct 18, 2022
danielbankhead
added a commit
that referenced
this pull request
Oct 19, 2022
shaffeeullah
pushed a commit
that referenced
this pull request
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: storage
Issues related to the googleapis/nodejs-storage API.
cla: yes
This human has signed the Contributor License Agreement.
size: s
Pull request size is small.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
credit to @jpambrun for identifying the fix
Test assertions needed to change slightly since they were asserting the
presence of functionality that doesn't actually work, specifically allowing
one to change the base url to not have
/storage/v1
. The code fundamentallydoes not support this at all, and is full of places that are hard coded to
always include that path element. The code does support having a base path
before that however, and so that is what I updated the tests to check.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1314
Fixes #2069