-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature request: allow stream in File.save #98
Comments
@fiws have you thought about using something like stream-to-promise? I think we're of the opinion that the streaming and non-streaming APIs shouldn't connect in that way. |
I would agree that However, I'm contradicting myself by suggesting What do you think @fiws? Obviously, you asked for the feature, but have you been able to make this work without the suggested change in a way that's not too cumbersome? Or do you feel even more strongly we should support this as time passed? Considering the above, I would be okay with a PR for this, although I don't consider it urgent. Its value might increase in time. |
Thanks for the response.
I would really like to see node figure out their promise/callback/event/stream mess. It feels like we're slowly moving towards a more promise based node core starting with You can close this issue if it bothers you. I would still like the feature though. |
I'll mark it the issue with "help wanted", so if anyone beats us to implementing it, great! |
For now, I think it's best to let the API stand, as-is. If you want to PR it, it should be a non-harmful change, although I don't think there is much demand from the community at this time. We can always re-open if we hear more requests for this. |
To avoid some boilerplate code with streams it would be nice to be able to pass a stream to
File.save
Example
This would be very useful when working with promises.
The text was updated successfully, but these errors were encountered: