New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store original encoded and signed identity JWT in OAuth2Credentials #680

Merged
merged 3 commits into from Nov 28, 2016

Conversation

Projects
None yet
3 participants
@clancychilds
Contributor

clancychilds commented Nov 23, 2016

For some authorization flows, including the Auth0 Delegation flow, the endpoint requires the original signed identity JWT to be sent. To support this, it is necessary to store the JWT alongside the decoded content.

This PR adds id_token_jwt as an element in the OAuth2Credentials. It also adds the logic to populate that element in parts of the flows that receive the identity token.

(This is the second PR for this as a previous PR had bad commit email addresses and was closed.)

Resolves: #678

@googlebot googlebot added the cla: yes label Nov 23, 2016

@theacodes theacodes merged commit f7f656d into googleapis:master Nov 28, 2016

3 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
@theacodes

This comment has been minimized.

Show comment
Hide comment
@theacodes

theacodes Nov 28, 2016

Member

Thanks for this, @clancychilds.

Member

theacodes commented Nov 28, 2016

Thanks for this, @clancychilds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment