Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Changed system test to use list_models() correctly #1397

Merged
merged 7 commits into from
May 27, 2022
Merged

fix: Changed system test to use list_models() correctly #1397

merged 7 commits into from
May 27, 2022

Conversation

samgoodman
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: vertex-ai Issues related to the googleapis/python-aiplatform API. labels May 27, 2022
@samgoodman samgoodman changed the title Goodmansam/modeluploadsystestfix feat: Changed system test to use list_models() correctly May 27, 2022
ivanmkc
ivanmkc approved these changes May 27, 2022
View reviewed changes
Copy link
Contributor

@ivanmkc ivanmkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samgoodman samgoodman changed the title feat: Changed system test to use list_models() correctly fix: Changed system test to use list_models() correctly May 27, 2022
@samgoodman samgoodman merged commit a3da19a into main May 27, 2022
@samgoodman samgoodman deleted the goodmansam/modeluploadsystestfix branch May 27, 2022 20:17
@release-please release-please bot mentioned this pull request May 27, 2022
Merged
@release-please release-please bot mentioned this pull request Jun 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanmkc ivanmkc ivanmkc approved these changes

Assignees
No one assigned
Labels
api: vertex-ai Issues related to the googleapis/python-aiplatform API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@samgoodman @ivanmkc