feat: add enable_simple_view to PipelineJob.list() #1614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
hilcj
reviewed
Aug 29, 2022
| "job_detail.pipeline_run_context", | ||
| "job_detail.pipeline_context", | ||
| ] | ||
| ) |
There was a problem hiding this comment.
nit - consider creating the path list as a constant somewhere that can be shared with the test file. Feel free to ignore if it needs too much refactor.
|
/lgtm |
jaycee-li
requested changes
Aug 29, 2022
| @@ -1026,6 +1027,7 @@ def _list( | |||
| cls_filter: Callable[[proto.Message], bool] = lambda _: True, | |||
| filter: Optional[str] = None, | |||
| order_by: Optional[str] = None, | |||
| read_mask: Optional[field_mask.FieldMask] = None, | |||
There was a problem hiding this comment.
Could you please add doc string for this and the one in the next method?
| enable_simple_view (bool): | ||
| Optional. Whether to pass the `read_mask` parameter to the list call. | ||
| This will improve the performance of calling list(). However, the | ||
| returned PipelineJob list will not include all fields for each PipelineJob. |
There was a problem hiding this comment.
I think here we can specify what fields are missing.
jaycee-li
approved these changes
Aug 29, 2022
rosiezou
added
do not merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
read_maskoption inPipelineJob.list()to improve performance. This will reduce the number of fields returned in the response for each PipelineJob.