Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: track slot time and add performance stats accessors to session object #725

Merged
merged 7 commits into from
May 28, 2024

Conversation

milkshakeiii
Copy link
Contributor

@milkshakeiii milkshakeiii commented May 28, 2024

Exposed properties session.slot_millis_sum and session.bytes_processed_sum can now be used to estimate performance/work done in a session. See internal issue 340278185

@milkshakeiii milkshakeiii requested review from a team as code owners May 28, 2024 16:53
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels May 28, 2024
@milkshakeiii
Copy link
Contributor Author

---BIGQUERY USAGE REPORT---
bq_dataframes_covid_line_graphs.ipynb - query count: 666, bytes processed sum: 5762544, slot millis sum: 1850067
bq_dataframes_covid_line_graphs.ipynb - query count: 43, bytes processed sum: 385451, slot millis sum: 1027972
bq_dataframes_covid_line_graphs.ipynb - query count: 40, bytes processed sum: 417171, slot millis sum: 497821
bq_dataframes_covid_line_graphs.ipynb - query count: 59, bytes processed sum: 563470, slot millis sum: 271811
bq_dataframes_covid_line_graphs.ipynb - query count: 12, bytes processed sum: 26556, slot millis sum: 100499
bq_dataframes_covid_line_graphs.ipynb - query count: 43, bytes processed sum: 10627962657, slot millis sum: 6160278
bq_dataframes_covid_line_graphs.ipynb - query count: 100, bytes processed sum: 14048626, slot millis sum: 653889
bq_dataframes_covid_line_graphs.ipynb - query count: 44, bytes processed sum: 5598362, slot millis sum: 176218
bq_dataframes_covid_line_graphs.ipynb - query count: 21, bytes processed sum: 810, slot millis sum: 144144
bq_dataframes_covid_line_graphs.ipynb - query count: 6, bytes processed sum: 34430816436, slot millis sum: 8633061
bq_dataframes_covid_line_graphs.ipynb - query count: 5, bytes processed sum: 26270652702, slot millis sum: 42959570
---total queries: 1039, total bytes: 71356234785, total slot millis: 62475330---

Copy link
Contributor

@chelsea-lin chelsea-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a comment for potential further extensions.

bigframes/session/__init__.py Show resolved Hide resolved
@milkshakeiii milkshakeiii merged commit 72e9583 into main May 28, 2024
20 of 21 checks passed
@milkshakeiii milkshakeiii deleted the b340278185-perf-data-on-session branch May 28, 2024 23:03
@milkshakeiii milkshakeiii changed the title feat: add slot_millis and add stats to session object feat: track slot time and add performance stats accessors to session object May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium. status: ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants