Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support type annotations with bpd.remote_function() and axis=1 (a preview feature) #730

Merged
merged 5 commits into from
May 30, 2024

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented May 29, 2024

Follow-up to #729 which should address the remaining failing doctest.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue 343447415 🦕

@tswast tswast requested review from a team as code owners May 29, 2024 19:26
@tswast tswast requested a review from chelsea-lin May 29, 2024 19:26
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels May 29, 2024
Copy link
Contributor

@chelsea-lin chelsea-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing that!

@tswast tswast enabled auto-merge (squash) May 30, 2024 19:15
@tswast tswast merged commit e5a2992 into main May 30, 2024
20 of 21 checks passed
@tswast tswast deleted the b343447415-remote_function-axis-1-type-annotation branch May 30, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants